potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r519725439
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,11 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
Review comment:
Happy if you have other proposals for those.
The provider setup.py and README generation is difficult to be done
otherwise unless we built in some dump of dependencies from setup.py in some
structured way, but we would need to do it as pre-commit whenever setup.py
changes.
We already do that for another case - to generate cross-provider
dependencies
https://github.com/apache/airflow/blob/master/airflow/providers/dependencies.json
- this file is a structured dump of which provider depends on which. It is
done from the sources rather than from setup.py automatically using pre-commit.
But I think it would not be a good way to keep that information in two
places (setup.py and another .json or similar).
Happy to discuss what other approaches we might take there if you can
propose something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
