potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r519726630
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,11 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
Review comment:
For inspiration - this is how we generate those depenencies.json . I
think they are useful to keep to see the dependencies:
```
- id: build-providers-dependencies
name: Build cross-dependencies for providers packages
entry:
"./scripts/ci/pre_commit/pre_commit_build_providers_dependencies.sh"
language: system
files: ^airflow/providers/.*\.py$|^tests/providers/.*\.py$
pass_filenames: false
```
This has been working for months now without anyone doing anything to keep
those in-sync and I saw quite a few cross-provider dependencies changed between
the few provider package releases we had. Thanks to that we do not have to do
anything to keep provider's cross-dependencies in sync.
And we have a nice history of changes to those cross-provider deps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
