potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r519722061
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,11 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
Review comment:
There are at lest few cases:
* We are importing it in some python pre-commits to verify setup.py
consistency, ordering, completeness
* We are importing it when automatically generating provider package
setup.py's or when we generate README files for those (we are retrieving
information about dependencies for each package so that we can produce a
documentation showing those dependencies and add the dependencies in the
generated setup.py for providers using a single source of truth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
