ashb commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532187749
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -67,7 +67,9 @@
class BigQueryHook(GoogleBaseHook, DbApiHook):
"""Interact with BigQuery. This hook uses the Google Cloud connection."""
- conn_name_attr = 'gcp_conn_id' # type: str
+ conn_name_attr = 'gcp_conn_id'
+ default_conn_name = 'google_cloud_default'
+ conn_type = 'google_cloud_platform'
Review comment:
@potiuk :+1:
@mik-laj If we want to be able to get a BigQuery hook to from
`Connection.get_hook` we'll need a unique type won't we?
(Right now the conn type for BQ is google_cloud_platform, but that means,
say, DataProc can't be google_cloud_platform)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
