uranusjr commented on a change in pull request #19084:
URL: https://github.com/apache/airflow/pull/19084#discussion_r733625839
##########
File path: airflow/providers/oracle/hooks/oracle.py
##########
@@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook':
dsn = conn.host
if conn.port is not None:
dsn += ":" + str(conn.port)
- if service_name or conn.schema:
- dsn += "/" + (service_name or conn.schema)
+ if service_name:
+ dsn += "/" + service_name
Review comment:
No, it's OK, but this does mean we're making a backward incompatible
change and will need to bump the provider's major version. I don't remember if
you need to do anything specific in code to call this out, but can you edit the
PR's description to make it clear this will need a new major version bump? (So
the release manager can notice it when compiling the release.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
