uranusjr commented on a change in pull request #19084:
URL: https://github.com/apache/airflow/pull/19084#discussion_r732255335
##########
File path: airflow/providers/oracle/hooks/oracle.py
##########
@@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook':
dsn = conn.host
if conn.port is not None:
dsn += ":" + str(conn.port)
- if service_name or conn.schema:
- dsn += "/" + (service_name or conn.schema)
+ if service_name:
+ dsn += "/" + service_name
Review comment:
Sorry, I meant to ask why the _change_ was needed, not this entire
block. This used to also consider `schema`, but does not anymore. Why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
