mehmax commented on a change in pull request #19084:
URL: https://github.com/apache/airflow/pull/19084#discussion_r732251123
##########
File path: airflow/providers/oracle/hooks/oracle.py
##########
@@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook':
dsn = conn.host
if conn.port is not None:
dsn += ":" + str(conn.port)
- if service_name or conn.schema:
- dsn += "/" + (service_name or conn.schema)
+ if service_name:
+ dsn += "/" + service_name
Review comment:
With this PR I generally fixed the meaning of conn.schema.
In my opinion it was never correct to append conn.schema to the dsn.
According to [cx_Oracle
Documentation](https://cx-oracle.readthedocs.io/en/latest/user_guide/connection_handling.html#easy-connect-syntax-for-connection-strings)
easy connect dsn is built like this:
`dbhost.example.com:1984/orclpdb1`
where `orclpdb1` is the service_name, not the schema.
Without a service_name, cx_Oracle is not able to connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
