uranusjr commented on a change in pull request #19084:
URL: https://github.com/apache/airflow/pull/19084#discussion_r732224449
##########
File path: airflow/providers/oracle/hooks/oracle.py
##########
@@ -136,6 +137,12 @@ def get_conn(self) -> 'OracleHook':
if mod is not None:
conn.module = mod
+ # if Connection.schema is defined, set schema after connecting
successfully
+ # cannot be part of conn_config
+ #
https://cx-oracle.readthedocs.io/en/latest/api_manual/connection.html?highlight=schema#Connection.current_schema
+ if schema is not None:
+ conn.current_schema = schema
Review comment:
This `current_schema` does not seem to be used anywhere? Why is it
needed? It seems to always be the same as `conn.schema`? (Because `schema =
conn.schema` on line 80 and it's never modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
