bugraoz93 edited a comment on pull request #19377: URL: https://github.com/apache/airflow/pull/19377#issuecomment-963768252
> As discussed - it needs backwards compatibiltty - so i am changing it to "request changes" so that it does not get merged accidentally. Hi @potiuk, I have made the changes regarding backward compatibility. I have made little changes in the hook and operator. Hook: I added a return type of Union which returns as follows. - If account_id is string (old format), returns List[AdsInsights] - If account_id is list (new format), returns Dict[str, List[AdsInsights]] Operator: I add a check for the return type of hook. - if List[AdsInsights] returned, the operator exports still in the same format and upload_as_account parameter useless. - if Dict[str, List[AdsInsights]] returned, user could choose export format with upload_as_account parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
