uranusjr commented on a change in pull request #19737:
URL: https://github.com/apache/airflow/pull/19737#discussion_r754965942
##########
File path: scripts/ci/libraries/_verify_image.sh
##########
@@ -19,11 +19,11 @@
function verify_image::verify_prod_image {
DOCKER_IMAGE="${1}"
export DOCKER_IMAGE
- "${SCRIPTS_CI_DIR}/images/ci_run_docker_tests.sh"
"${AIRFLOW_SOURCES}/docker_tests/prod_image.py"
+ "${SCRIPTS_CI_DIR}/images/ci_run_docker_tests.py"
"${AIRFLOW_SOURCES}/docker_tests/prod_image.py"
Review comment:
Because shebang requires an additional trip to the kernel, and the `env`
context is sometimes finnicky to debug if somethings goes wrong. It’s not
exactly wrong (and definitely useful), but if we can be explicit, we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
