potiuk commented on a change in pull request #19737:
URL: https://github.com/apache/airflow/pull/19737#discussion_r755057294
##########
File path: docker_tests/docker_tests_utils.py
##########
@@ -28,7 +29,7 @@
def run_command(cmd: List[str], print_output_on_error: bool = True, **kwargs):
- print(f"$ {' '.join(c for c in cmd)}")
+ print(f"$ {' '.join(shlex.quote(c) for c in cmd)}")
Review comment:
Side - comment: Following the learnings from breeze implementation I am
planning (this is also part of the internship work that we planned) to document
all such assumptions in the format of ADRs https://adr.github.io/ so that we
avoid the problem that a lot of decisions with Breeze did not have enough
"context" explained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
