potiuk commented on a change in pull request #19737:
URL: https://github.com/apache/airflow/pull/19737#discussion_r755053597



##########
File path: docker_tests/docker_tests_utils.py
##########
@@ -28,7 +29,7 @@
 
 
 def run_command(cmd: List[str], print_output_on_error: bool = True, **kwargs):
-    print(f"$ {' '.join(c for c in cmd)}")
+    print(f"$ {' '.join(shlex.quote(c) for c in cmd)}")

Review comment:
       Basically: with all those BashToPython changes we should assume that 
they are used by someone who has no dev env setup, nothing installed, just 
python (3.6+) installed on their OS (Modern Linux, MacOS, Windows). There 
should be no more prerequisites. Later we might add docker/docker-compose to 
the list of those prerequisites, but that should really be it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to