potiuk commented on a change in pull request #19737:
URL: https://github.com/apache/airflow/pull/19737#discussion_r755051427
##########
File path: docker_tests/docker_tests_utils.py
##########
@@ -28,7 +29,7 @@
def run_command(cmd: List[str], print_output_on_error: bool = True, **kwargs):
- print(f"$ {' '.join(c for c in cmd)}")
+ print(f"$ {' '.join(shlex.quote(c) for c in cmd)}")
Review comment:
Just to add a little more context on that one as well:
And to add on that - we do not know what python version the user has. The
idea of this script (similarly as previous BASH scripts) is that it should run
pretty much everywhere without any "extra" assumptions. Just pytho3 should be
enough to run the script - I think we can - for now assume safely have
`python3.6+` as the "big assumption".
I would also love this to make sure it also works on Windows without WSL2 -
this was the thing that was missing with `bash` approach - but ideally the
workflow should be exactly the same for pure-windows developers too.
So we have to be extra careful this one also works for Windows (this is
something that we will likely add during the Internship - and some of our
interns are using Windows primarily - so this is something they will be able to
check and likely we can even add tests for it in GitHub on Windows runners (but
that's a bit later stage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
