blag commented on code in PR #26052:
URL: https://github.com/apache/airflow/pull/26052#discussion_r957864072
##########
airflow/datasets/manager.py:
##########
@@ -68,6 +68,9 @@ def _queue_dagruns(self, dataset: DatasetModel, session:
Session) -> None:
for dag_id in consuming_dag_ids:
session.merge(DatasetDagRunQueue(dataset_id=dataset.id,
target_dag_id=dag_id))
+ def resolve_dataset_model(self, dataset: Dataset) -> DatasetModel:
+ return DatasetModel(uri=dataset.uri, extra=dataset.extra)
Review Comment:
Since this is a public method, consider adding `**kwargs` for
forward-compatibility. That way, if the signature changes in the future, plugin
authors don't have to resort to hacks (like figuring out Airflow version or
checking the function signature) before calling it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
