dstandish commented on code in PR #26052:
URL: https://github.com/apache/airflow/pull/26052#discussion_r957875402
##########
airflow/datasets/manager.py:
##########
@@ -68,6 +68,9 @@ def _queue_dagruns(self, dataset: DatasetModel, session:
Session) -> None:
for dag_id in consuming_dag_ids:
session.merge(DatasetDagRunQueue(dataset_id=dataset.id,
target_dag_id=dag_id))
+ def resolve_dataset_model(self, dataset: Dataset) -> DatasetModel:
Review Comment:
right... easier to not like the naming than to come up with good naming :)
but ... is it not a mutation?
oh cus you're returning a DatasetModel class instead of a Dataset class...
well... i guess we could _make it_ a mutation hook.... and just return a
[possibly] mutated Dataset object.... not sure .... maybe @blag will save the
day with some brilliance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
