ashb commented on code in PR #26052:
URL: https://github.com/apache/airflow/pull/26052#discussion_r958350721
##########
airflow/models/dataset.py:
##########
@@ -76,7 +76,9 @@ class DatasetModel(Base):
@classmethod
def from_public(cls, obj: Dataset) -> DatasetModel:
Review Comment:
I would probably say lets remove this function from this class entirely and
move it to on the Manager instead -- that also might give us a better name than
`resolve`.
How about `model = manager.from_public(dataset)` or `model =
manager.make_dataset_model(dataset)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
