ashb commented on code in PR #26052:
URL: https://github.com/apache/airflow/pull/26052#discussion_r958351814
##########
airflow/datasets/manager.py:
##########
@@ -68,6 +68,9 @@ def _queue_dagruns(self, dataset: DatasetModel, session:
Session) -> None:
for dag_id in consuming_dag_ids:
session.merge(DatasetDagRunQueue(dataset_id=dataset.id,
target_dag_id=dag_id))
+ def resolve_dataset_model(self, dataset: Dataset) -> DatasetModel:
+ return DatasetModel(uri=dataset.uri, extra=dataset.extra)
Review Comment:
@blag I don't think that's necessary here, any "kwargs" should come from the
dataset object passed in, otherwise there is no way for the user to get them in
to this call in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
