shubham22 commented on code in PR #27823: URL: https://github.com/apache/airflow/pull/27823#discussion_r1030738579
########## airflow/providers/amazon/aws/hooks/base_aws.py: ########## @@ -25,9 +25,13 @@ from __future__ import annotations Review Comment: 1. I agree that if you already know a list of known dags, you can figure it out. If there is a better suggestion that makes salt unknown but keeps it same across the DAG runs, I think that would be preferred. 2. I like the idea that we are not adding this config on the user. But, does it solve the problem we started with i.e. providing more privacy to the users? Would we end up adding this config for every provider out there? I still think it is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
