Taragolis commented on code in PR #27823:
URL: https://github.com/apache/airflow/pull/27823#discussion_r1030111141
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -25,9 +25,13 @@
from __future__ import annotations
Review Comment:
1. I can't say that hashes with known algorithm and salt is "completely
private". It can't be easily revert however can be easily identify if has a
list of known dags, e.g. "5ee762d8-7bac-5131-9887-03dcab3b7111" stands for
"example_s3".
We could talk about this kind of stuff for ages and the result would be that
more people would like make/buy "tin foil hat".
2. This config intend to use by vendors of Airflow-as-a-service not end
users it also could be not a general Airflow Config it might be just an
environment variable "AIRFLOW_BOTOCORE_ADDITIONAL_UA". So this callable could
return any vendor specific info, for example:
- Version of MWAA
- Version of local runner
- Version of Google Composer
- Version of Astronomer
- Any DAG/Callable related stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
