ferruzzi commented on code in PR #27823: URL: https://github.com/apache/airflow/pull/27823#discussion_r1032706825
########## airflow/providers/amazon/aws/hooks/base_aws.py: ########## @@ -25,9 +25,13 @@ from __future__ import annotations Review Comment: Sorry for the wait, I wanted to think this through and make sure I understood the implications. If I am understanding correctly: doing it the way it is currently written means that we do not get any data from when Airflow itself connects to SecretsManager. That was somewhat accidental, but I consider that an absolute win. I/We don't want to be "snooping" on traffic where Airflow is retrieving secrets. The main goal here is to understand which services and endpoints are being used in DAGs so we can prioritize adding new hooks and operators accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
