uranusjr commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1071928325
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
The False case feels unnecessarily complicated to me; I’d expect
`log_containers=False` to not log anything. I’d make this take
1. `list[str]`: A list of container names
2. `str`: One single container name
3. `Literal[True]`: Log everything
and make the argument default to `BASE_CONTAINER_NAME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
