dstandish commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1082906748
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
> but can I assume that this will be the final design?
and
> No. you can't. There is always possibility that others will come with more
comments or find something else
Maybe the sentiment expressed here is really, "before I make this change,
what do others think? do you agree with this path forward?" :)
It's a reasonable thing to ask. And I understand it's hard as contributor
sometimes to wait for reviews and sometimes get conflicting requests and this
kind of thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
