potiuk commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1082797194
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
> but can I assume that this will be the final design?
No. you can't. There is always possibility that others will come with more
comments or find something else. So you have no gurarantees. It happens that I
have to (even as maintainer) rewrite and fix and split and merge the same PR
10-20 times. This is possible.
I am not saying this will happen in this case. Just that you have no
guarantees that there will be no more comments. You have to deal with this. And
treat it as a learning opportunity. I - for one - I am super happy when
someone suggest a change that allows to remove half of the code I wrote and
iterated over in a PR of mine even if it's done after weeks of iterating.
The end result is better, often the comment would not even come if I did not
iterate multiple times in the process. I've learned somethings. Only pluses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
