potiuk commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1082919473
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
Sometimes those committers have 100 of PRs to look like. I suggest you to
follow the request you got, otherwise you might wait for a long time. In the
meantime after you do it it, maybe another commiter will have a look and have
another idea. But you can follow what you got now. Or wait (sometimes weeks)
for other's comment.
It's enough to have approval of single commiter to get things merged in
non-critical code.
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
Sometimes those committers have 100 of PRs to look at. I suggest you to
follow the request you got, otherwise you might wait for a long time. In the
meantime after you do it it, maybe another commiter will have a look and have
another idea. But you can follow what you got now. Or wait (sometimes weeks)
for other's comment.
It's enough to have approval of single commiter to get things merged in
non-critical code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
