vandonr-amz commented on PR #29245: URL: https://github.com/apache/airflow/pull/29245#issuecomment-1410954197
> We're only counting jobs whose name matches [here](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/hooks/sagemaker.py#L1022) Oh yes my bad, I read the code too fast. Having a random number rather than beautiful sequence is not better in itself of course, but I think the price to pay for this little nice thing is too high. Instead of an O(1) operation, we end up doing potentially hundreds of network calls, with added wait time to account for throttling errors, every time we create a job. All this just so that we can eventually have a nice number in a list that is ordered by creation date by default anyway. We also run the risk of collisions if two jobs with the same name are created at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
