dylanbstorey commented on code in PR #30406:
URL: https://github.com/apache/airflow/pull/30406#discussion_r1155145448
##########
airflow/triggers/external_task.py:
##########
@@ -80,7 +80,7 @@ async def run(self) -> typing.AsyncIterator["TriggerEvent"]:
while True:
num_tasks = await self.count_tasks()
if num_tasks == len(self.execution_dates):
- yield TriggerEvent(True)
+ yield TriggerEvent(self.serialize())
Review Comment:
I think yielding more from the trigger is preferable to restricting the
interface for this one use case. It provides for future use cases without
needing a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
