dylanbstorey commented on code in PR #30406:
URL: https://github.com/apache/airflow/pull/30406#discussion_r1163991657
##########
airflow/triggers/external_task.py:
##########
@@ -144,7 +144,7 @@ async def run(self) -> typing.AsyncIterator["TriggerEvent"]:
while True:
num_dags = await self.count_dags()
if num_dags == len(self.execution_dates):
- yield TriggerEvent(True)
+ yield TriggerEvent(self.serialize())
Review Comment:
good call - i went ahead and used the the serialize method to produce the
event back in the mocked return to make sure the interface is directly used in
the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
