hussein-awala commented on code in PR #30406:
URL: https://github.com/apache/airflow/pull/30406#discussion_r1163742381
##########
airflow/triggers/external_task.py:
##########
@@ -144,7 +144,7 @@ async def run(self) -> typing.AsyncIterator["TriggerEvent"]:
while True:
num_dags = await self.count_dags()
if num_dags == len(self.execution_dates):
- yield TriggerEvent(True)
+ yield TriggerEvent(self.serialize())
Review Comment:
This solution is based on the result of `self.serialize()`, I wonder if we
can add a test for this method (without mocking it) to make sure that when
someone changes it, a test on `test_trigger_dagrun` blocks it until update the
code that uses it. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
