ferruzzi commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1181812175


##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
             "local_task_job.task_exit."
             
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
         )
+        # Same metric with tagging

Review Comment:
   Had a chat with Niko offline and we've decided the redundant calls here are 
the lesser of the two evils and will make it easier to deprecate the long names 
at a later date rather than hiding the problem.  I'm going to roll back that 
change in a coming update to this PR and leave all the duplicate calls in place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to