howardyoo commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1181819698
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
"local_task_job.task_exit."
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
)
+ # Same metric with tagging
Review Comment:
@ferruzzi , BTW, I recently met this particular metric to be somewhat of a
problem where when exported to datadog, these long metric names were
introducing too high of the cardinality, FYI, had to ask around what were the
usage of this metric and, somebody explained that it was an instrumentation
that somebody made which kept track of whether the local task job run did end
successfully or hung up (or exited with error). This metric would only be for
local task job runs, and therefore, I wonder if this metric is actually that
much useful at all or not, since I do feel like this is not actually a
telemetry data (e.g. metric), but more so like an event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
