o-nikolas commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1535527676
Hey folks, Thanks for weighing in. Some thoughts and more context: I don't personally see this PR as being exceptionally dangerous or difficult to review beyond a standard PR that shuffles a few classes around. I think we've all seen and reviewed plenty of PRs that are WAY larger. It will be very tedious and time consuming to maintain this branch for months, most changes to the kube executor cause conflicts and every time you manually resolve them there is more and more chance you transcribe incorrectly and cause bugs, not to mention how time consuming it is. So I suspect this may just rot by the end of two months. Lastly, the motivation for this work was to make executors fast enough to load so that they can be part of the code path for CLI command generation. In other words, to ship one of the last AIP-51 milestones (Executors vending CLI commands) this is required work. So that AIP completion will also be blocked if this is parked. All that being said, if after reading the above, folks still think this PR is too exceptionally dangerous, then the community has spoken and it will have to wait :slightly_smiling_face: Thanks again for taking the time to review :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
