o-nikolas commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1548269050
> I think that is the missing piece of information that changes my view (or maybe I missed it). I propsed delying that one because I thought the only reson for having this chang is load time optimisation (which would not be used anyhow before 2.7 is releasd). > > It fhere are other reasons and follow-up PR that are waitng for that one, this is quite entirely a different story. In such case I agree, that merging that one should not wait for too long and in this case (especially if you are going to help with cherry-picking) it's perfectly fine to merge it. The question is - is it really the case? Are those other PR really depending on that one? Or can they be done without the optimisation and the optimisation can be applied later? > > * If it is the former - It would be stupid to wait with changes that are blocking further changes. > > * If it is the latter - I would proceed with the other change now and defer applying this optimisation till before the cut-off > > > I have completely no problem if it's the former with merging it now. Hey @potiuk thanks for reconsidering! Indeed this PR and the similar Celery PR both block #29055 since there would be too much of a regression in CLI execution time without them. I resolved the latest conflicts with this branch last week, I think it should be mergeable into main now if you're willing :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
