o-nikolas commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1544809198
> have you thought about perhaps adding some performance testing to monitor this? i think it's something that could probably be done through our "system tests" e.g. with bash operator running some airflow CLI commands in a loop. Indeed! I have done some thinking on this: since these optimizations are not runtime they're only import/load time you could have a unit/integ test which imports the modules and times how long that takes. BUT you would need some way to execute this in a clean namespace and I also find that time-based tests like this often give more problems than they solve, since they can be flakey and fail if the machine they run on causes things to run slowly for any number of reasons. You can make the limit that triggers a failure large, but then small regressions can creep in. So I haven't found a way to square that circle, I'm open to ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
