howardyoo commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1181957865
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
"local_task_job.task_exit."
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
)
+ # Same metric with tagging
Review Comment:
> Can you start a ticket/discussion for this? I know a few other folks have
mentioned certain stats that either don't work or don't serve the purpose they
claim to. Let's get a discussion going and collect those in one place. Once
this OTel support is in, we can go through that list and clean stuff up. At
that point we'll already be deprecating and refactoring metrics stuff and will
likely need a major release, so it seems like a good time to go though with
those fixes/changes as well.
Sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
