potiuk commented on code in PR #32052:
URL: https://github.com/apache/airflow/pull/32052#discussion_r1239681677
##########
airflow/www/static/js/connection_form.js:
##########
@@ -123,6 +125,16 @@ function applyFieldBehaviours(connection) {
*/
function handleTestConnection(connectionType, testableConnections) {
const testButton = document.getElementById("test-connection");
+
+ if (!configTestConnectionEnabled) {
+ // If test connection is not enabled in config, disable button and display
toolip
+ // alerting the user.
+ $(testButton)
+ .prop("disabled", true)
+ .attr("title", "Test connection is not enabled in config.");
Review Comment:
I think It's kinda good to see it so that it is discoverable that you can do
it and explain that you need to talk to your admin to enable it (as a tooltip).
This is especially important, I think, for existing users. If suddenly the
button disappears, nobody (especially users who could use the "Test connection"
before) will read the release notes or documentation, we will be opening for
floodgate of issues "The `test connection` button disappeared - please fix it".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
