potiuk commented on code in PR #32052:
URL: https://github.com/apache/airflow/pull/32052#discussion_r1239687219
##########
airflow/www/static/js/connection_form.js:
##########
@@ -123,6 +125,16 @@ function applyFieldBehaviours(connection) {
*/
function handleTestConnection(connectionType, testableConnections) {
const testButton = document.getElementById("test-connection");
+
+ if (!configTestConnectionEnabled) {
+ // If test connection is not enabled in config, disable button and display
toolip
+ // alerting the user.
+ $(testButton)
+ .prop("disabled", true)
+ .attr("title", "Test connection is not enabled in config.");
Review Comment:
My suggestion will also be to add. "Talk to your deployment manager to
enable it." or similar. I think it is time to start introducing the different
kinds of users for our security model and once we explain the different kinds
of users, use it consistently as messaging.
I think having clear responsibilities "who is responsible for what" is also
part of the user "education" we have to do a bit. The average user will not
know that they need to talk to the "deplomen manager" I think (if they are on a
corporate installation or managed service). Which config? How to enable it?
Where to find it ?
I think there are often just "users" who who do not know (and should not
even need to know actually) what Airflow configuration is. But if we tell them
"talk to the guys that manage your Airflow", they will know what to do (rather
than trying to look on their own or create issues in airflow repo "I see this
messsage, what should i do" (happens).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
