jedcunningham commented on code in PR #32052:
URL: https://github.com/apache/airflow/pull/32052#discussion_r1239804895
##########
airflow/www/static/js/connection_form.js:
##########
@@ -123,6 +125,16 @@ function applyFieldBehaviours(connection) {
*/
function handleTestConnection(connectionType, testableConnections) {
const testButton = document.getElementById("test-connection");
+
+ if (!configTestConnectionEnabled) {
+ // If test connection is not enabled in config, disable button and display
toolip
+ // alerting the user.
+ $(testButton)
+ .prop("disabled", true)
+ .attr("title", "Test connection is not enabled in config.");
Review Comment:
Good point, but playing devils advocate :) I wonder if we need a non-boolean
value for this then? What about the admin who chooses not to allow their users
to test connections but constantly gets asked about it? Allowing admins to hide
it could save them the same heartache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
