potiuk commented on code in PR #32052:
URL: https://github.com/apache/airflow/pull/32052#discussion_r1239937658
##########
airflow/www/static/js/connection_form.js:
##########
@@ -123,6 +125,16 @@ function applyFieldBehaviours(connection) {
*/
function handleTestConnection(connectionType, testableConnections) {
const testButton = document.getElementById("test-connection");
+
+ if (!configTestConnectionEnabled) {
+ // If test connection is not enabled in config, disable button and display
toolip
+ // alerting the user.
+ $(testButton)
+ .prop("disabled", true)
+ .attr("title", "Test connection is not enabled in config.");
Review Comment:
Yeah. Very much agree with @jedcunningham :). And agree that being able to
disable it completely is a good idea from Deployment manager's perspective. I
am torn between the defaults there though. Should new airflow has "remove" by
defult or "disable". If only we could see if we are upgrading from older
version or installing airflow from the scratch, that would be cool to have
`remove` by default and `disable` when you migrate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
