vandonr-amz commented on code in PR #32513:
URL: https://github.com/apache/airflow/pull/32513#discussion_r1261805082


##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1025,11 +1034,12 @@ def __init__(
         self.aws_conn_id = aws_conn_id
         self.release_label = release_label
         self.job_type = job_type
-        self.wait_for_completion = wait_for_completion
+        self.wait_for_completion = False if deferrable else wait_for_completion

Review Comment:
   what I'm saying is that if you have an operator where `wait_for_completion = 
False` and you set your config to `operators.default_deferrable = True` because 
yeah sure you want to free workers, then suddenly your operators start waiting 
when they weren't before and that can be a bit confusing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to