syedahsn commented on code in PR #32513:
URL: https://github.com/apache/airflow/pull/32513#discussion_r1261910220
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1025,11 +1034,12 @@ def __init__(
self.aws_conn_id = aws_conn_id
self.release_label = release_label
self.job_type = job_type
- self.wait_for_completion = wait_for_completion
+ self.wait_for_completion = False if deferrable else wait_for_completion
Review Comment:
You have a good point, but a counter point is that it would be confusing for
users to set `deferrable=True` for an operator, and not see any difference in
behaviour.
> then suddenly your operators start waiting when they weren't before
I think the solution to this is to be very clear that `deferrable=True`
implies `wait_for_completion=True`.
Either way,I think this is a decision that we need to clear up, and then
implement everywhere. A quick search showed that we have an inconsistent
definition of how `deferrable` and `wait_for_completion` work with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
