syedahsn commented on code in PR #32513:
URL: https://github.com/apache/airflow/pull/32513#discussion_r1261802531
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1025,11 +1034,12 @@ def __init__(
self.aws_conn_id = aws_conn_id
self.release_label = release_label
self.job_type = job_type
- self.wait_for_completion = wait_for_completion
+ self.wait_for_completion = False if deferrable else wait_for_completion
Review Comment:
> I was actually wondering with the new default if it'd make sense to defer
only if deferrable && wait_for_completion ?
Why would that be the case? In this case `deferrable` and
`wait_for_completion` don't really interact (i.e. if we defer, then we never
check for `wait_for_completion`) But I think `deferrable=True` implies
`wait_for_completion=True`.
A lot of the time, `wait_for_completion` is set as `False` by default, which
would be confusing for users if they pass `deferrable=True` but we don't defer
because `wait_for_completion` is `False`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
