o-nikolas commented on code in PR #32525:
URL: https://github.com/apache/airflow/pull/32525#discussion_r1263072460
##########
airflow/www/fab_security/manager.py:
##########
@@ -208,12 +206,6 @@ def oauth_tokengetter(token=None):
userstatschartview = UserStatsChartView
permissionmodelview = PermissionModelView
- @cached_property
- def resourcemodelview(self):
Review Comment:
I see, so the override class will be the new final home for all this code,
and other auth managers don't need any of it (it's still not clear to me what
they'll replace it with or why they don't need it, but I guess I don't _need_
those details).
My only last comment would be that calling that new class an Override seems
a bit odd. It's not really an override if it's going to be the official/final
location for all this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
