o-nikolas commented on code in PR #32525:
URL: https://github.com/apache/airflow/pull/32525#discussion_r1263921983


##########
airflow/www/fab_security/manager.py:
##########
@@ -208,12 +206,6 @@ def oauth_tokengetter(token=None):
     userstatschartview = UserStatsChartView
     permissionmodelview = PermissionModelView
 
-    @cached_property
-    def resourcemodelview(self):

Review Comment:
   > I think Airflow needs a security manager regardless of the auth manager. I 
assume there is code in these security managers which will stay in the security 
manager.
   
   I think this is the bit I've been trying to get at, the default 
implementation I mentioned above. Knowing that it makes a bit more sense. I'm 
curious to see what's left over after all the FAB stuff is removed, and to what 
degree any default implementation is left over. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to