vincbeck commented on code in PR #32525:
URL: https://github.com/apache/airflow/pull/32525#discussion_r1263709950
##########
airflow/www/fab_security/manager.py:
##########
@@ -208,12 +206,6 @@ def oauth_tokengetter(token=None):
userstatschartview = UserStatsChartView
permissionmodelview = PermissionModelView
- @cached_property
- def resourcemodelview(self):
Review Comment:
It is still an override because *I think* Airflow needs a security manager
regardless of the auth manager. I assume there is code in these security
managers which will stay in the security manager. I am not sure what code and I
guess this is something we'll find out while working on the AIP. But yes, I
still expect to have a security manager by default which does the very minimal
and nothing related to FAB auth. On top of that default security manager, auth
managers (a lot of managers ...) can override it if they want/need. That's my
current mental picture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
