vandonr-amz commented on code in PR #32683:
URL: https://github.com/apache/airflow/pull/32683#discussion_r1268507037
##########
airflow/providers/amazon/aws/hooks/sagemaker.py:
##########
@@ -1073,14 +1074,19 @@ def start_pipeline(
:param display_name: The name this pipeline execution will have in the
UI. Doesn't need to be unique.
:param pipeline_params: Optional parameters for the pipeline.
All parameters supplied need to already be present in the pipeline
definition.
- :param wait_for_completion: Will only return once the pipeline is
complete if true.
- :param check_interval: How long to wait between checks for pipeline
status when waiting for
- completion.
- :param verbose: Whether to print steps details when waiting for
completion.
- Defaults to true, consider turning off for pipelines that have
thousands of steps.
:return: the ARN of the pipeline execution launched.
"""
+ if wait_for_completion or check_interval is not None:
+ warnings.warn(
+ "parameter `wait_for_completion` and `check_interval` are
deprecated, "
+ "remove them and call check_status yourself if you want to
wait for completion",
+ AirflowProviderDeprecationWarning,
+ stacklevel=2,
+ )
+ if check_interval is None:
+ check_interval = 30
Review Comment:
because it's used only if `wait_for_completion`, and if we deprecate that,
then we can deprecate this param as well which becomes useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
