ferruzzi commented on code in PR #32683:
URL: https://github.com/apache/airflow/pull/32683#discussion_r1273917918


##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -1073,32 +1105,68 @@ def __init__(
         pipeline_exec_arn: str,
         wait_for_completion: bool = False,
         check_interval: int = CHECK_INTERVAL_SECOND,
+        waiter_max_attempts: int = 9999,

Review Comment:
   I think personally I'd do it the other way, have a conf value to set a 
global interval and adjust the max attempts, but either way, I think it's the 
right direction to consider in the future.
   
   Approved this as-is, that's a change for another day.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to