Lee-W commented on code in PR #32683:
URL: https://github.com/apache/airflow/pull/32683#discussion_r1268129021
##########
airflow/providers/amazon/aws/triggers/sagemaker.py:
##########
@@ -115,3 +121,79 @@ async def run(self):
status_args=[self._get_response_status_key(self.job_type)],
)
yield TriggerEvent({"status": "success", "message": "Job
completed."})
+
+
+class SageMakerPipelineTrigger(BaseTrigger):
+ """Trigger to wait for a sagemaker pipeline execution to finish."""
+
+ class Type(IntEnum):
+ """Type of waiter to use."""
+
+ COMPLETE = 1
+ STOPPED = 2
+
+ def __init__(
+ self,
+ waiter_type: Type,
+ pipeline_execution_arn: str,
+ waiter_delay: int,
+ waiter_max_attempts: int,
+ aws_conn_id: str,
+ ):
+ self.waiter_type = waiter_type
+ self.pipeline_execution_arn = pipeline_execution_arn
+ self.waiter_delay = waiter_delay
+ self.waiter_max_attempts = waiter_max_attempts
+ self.aws_conn_id = aws_conn_id
+
+ def serialize(self) -> tuple[str, dict[str, Any]]:
+ return (
+ "airflow.providers.amazon.aws.triggers.sagemaker.SageMakerTrigger",
+ {
+ "waiter_type": self.waiter_type.value, # saving the int value
here
+ "pipeline_execution_arn": self.pipeline_execution_arn,
+ "waiter_delay": self.waiter_delay,
+ "waiter_max_attempts": self.waiter_max_attempts,
+ "aws_conn_id": self.aws_conn_id,
+ },
+ )
+
+ _waiter_name = {
+ Type.COMPLETE: "PipelineExecutionComplete",
+ Type.STOPPED: "PipelineExecutionStopped",
+ }
+
+ async def run(self) -> AsyncIterator[TriggerEvent]:
+ attempts = 0
+ hook = SageMakerHook(aws_conn_id=self.aws_conn_id)
+ async with hook.async_conn as conn:
+ waiter = hook.get_waiter(self._waiter_name[self.waiter_type])
+ while attempts < self.waiter_max_attempts:
+ attempts = attempts + 1
+ try:
+ await waiter.wait(
+ PipelineExecutionArn=self.pipeline_execution_arn,
WaiterConfig={"MaxAttempts": 1}
+ )
+ yield TriggerEvent({"status": "success", "value":
self.pipeline_execution_arn})
+ break # we reach this point only if the waiter met a
success criteria
Review Comment:
hmmm... interesting 🤔 yep, that's something I missed. Is there a way for us
to reproduce it?
##########
airflow/providers/amazon/aws/triggers/sagemaker.py:
##########
@@ -115,3 +121,79 @@ async def run(self):
status_args=[self._get_response_status_key(self.job_type)],
)
yield TriggerEvent({"status": "success", "message": "Job
completed."})
+
+
+class SageMakerPipelineTrigger(BaseTrigger):
+ """Trigger to wait for a sagemaker pipeline execution to finish."""
+
+ class Type(IntEnum):
+ """Type of waiter to use."""
+
+ COMPLETE = 1
+ STOPPED = 2
+
+ def __init__(
+ self,
+ waiter_type: Type,
+ pipeline_execution_arn: str,
+ waiter_delay: int,
+ waiter_max_attempts: int,
+ aws_conn_id: str,
+ ):
+ self.waiter_type = waiter_type
+ self.pipeline_execution_arn = pipeline_execution_arn
+ self.waiter_delay = waiter_delay
+ self.waiter_max_attempts = waiter_max_attempts
+ self.aws_conn_id = aws_conn_id
+
+ def serialize(self) -> tuple[str, dict[str, Any]]:
+ return (
+ "airflow.providers.amazon.aws.triggers.sagemaker.SageMakerTrigger",
+ {
+ "waiter_type": self.waiter_type.value, # saving the int value
here
+ "pipeline_execution_arn": self.pipeline_execution_arn,
+ "waiter_delay": self.waiter_delay,
+ "waiter_max_attempts": self.waiter_max_attempts,
+ "aws_conn_id": self.aws_conn_id,
+ },
+ )
+
+ _waiter_name = {
+ Type.COMPLETE: "PipelineExecutionComplete",
+ Type.STOPPED: "PipelineExecutionStopped",
+ }
+
+ async def run(self) -> AsyncIterator[TriggerEvent]:
+ attempts = 0
+ hook = SageMakerHook(aws_conn_id=self.aws_conn_id)
+ async with hook.async_conn as conn:
+ waiter = hook.get_waiter(self._waiter_name[self.waiter_type])
+ while attempts < self.waiter_max_attempts:
+ attempts = attempts + 1
+ try:
+ await waiter.wait(
+ PipelineExecutionArn=self.pipeline_execution_arn,
WaiterConfig={"MaxAttempts": 1}
+ )
+ yield TriggerEvent({"status": "success", "value":
self.pipeline_execution_arn})
+ break # we reach this point only if the waiter met a
success criteria
Review Comment:
hmmm... interesting 🤔 yep, that's something I missed. Is there a way for us
to reproduce it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
