vandonr-amz commented on code in PR #32683:
URL: https://github.com/apache/airflow/pull/32683#discussion_r1273887568


##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -1073,32 +1105,68 @@ def __init__(
         pipeline_exec_arn: str,
         wait_for_completion: bool = False,
         check_interval: int = CHECK_INTERVAL_SECOND,
+        waiter_max_attempts: int = 9999,

Review Comment:
   We should certainly uniformize this a bit between operators.
   Currently, some wait forever by default (like this one), some others have a 
set value...
   It's not an easy task though, because different operators might have 
different "expected waiting times".
   This could be achieved by setting different poll intervals, but always the 
same max attempts maybe ?
   And maybe a global conf to set it yeah ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to