kaxil commented on code in PR #34042:
URL: https://github.com/apache/airflow/pull/34042#discussion_r1314334593


##########
airflow/serialization/serialized_objects.py:
##########
@@ -438,7 +438,7 @@ def serialize(
             json_pod = PodGenerator.serialize_pod(var)
             return cls._encode(json_pod, type_=DAT.POD)
         elif isinstance(var, DAG):
-            return SerializedDAG.serialize_dag(var)
+            return cls._encode(SerializedDAG.serialize_dag(var), type_=DAT.DAG)

Review Comment:
   Also, be careful about backwards-incompatible changes for this.
   
   And if for AIP-44 we absolutely need this sort of change, that will probably 
be more involved than just the DAG object



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to