uranusjr commented on code in PR #34042:
URL: https://github.com/apache/airflow/pull/34042#discussion_r1315661359
##########
airflow/serialization/pydantic/dag_run.py:
##########
@@ -26,7 +26,7 @@
class DagRunPydantic(BaseModelPydantic):
"""Serializable representation of the DagRun ORM SqlAlchemyModel used by
internal API."""
- id: int
+ id: Optional[int]
Review Comment:
I’m not sure Job should have an optional ID either. Maybe make this not
optional for now and we can punt this until it’s nocessary for a model. It’s
always easier to remove a restriction than add one.
##########
airflow/serialization/pydantic/dag_run.py:
##########
@@ -26,7 +26,7 @@
class DagRunPydantic(BaseModelPydantic):
"""Serializable representation of the DagRun ORM SqlAlchemyModel used by
internal API."""
- id: int
+ id: Optional[int]
Review Comment:
I’m not sure Job should have an optional ID either. Maybe make this not
optional for now and we can punt this until it’s nocessary for a model. It’s
always easier to remove a restriction than add one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
